Make Encoding accessible from speech.Encoding. #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
force-pushed
the
speech-streaming-part-1
branch
from
7ac073b to
76afbe3
Compare
|
LGTM. Nice catch on the misaligned text in the docs. Also, FWIW the import didn't need to change in the unit tests, just in user facing stuff (i.e. we don't feel like importing members directly from modules is a burden, but it is a burden on users to keep track of all the many modules we have) |
|
Ok, I have some questions about unit tests in general, I should probably open an issue for them? |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…art-1 Make Encoding accessible from speech.Encoding.
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhermes per our discussion the other day, this moves Encoding to speech.